8000 Protect against Docker hanging trying to talk to a non-existent plugin by bboreham · Pull Request #2292 · weaveworks/weave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

Protect against Docker hanging trying to talk to a non-existent plugin #2292

Merged
merged 1 commit into from
May 18, 2016
Merged

Protect against Docker hanging trying to talk to a non-existent plugin #2292

merged 1 commit into from
May 18, 2016

Conversation

bboreham
Copy link
Contributor

Remove the Unix socket from the filesystem before doing volume operations, if the plugin is not running.

Fixes #2286

(Note the comparable problem for network operations is not helped by this measure. I.e. if you:

$ weave launch
$ docker kill weaveplugin
$ weave reset

then weave reset will hang for a while trying to remove the weave network.)

@bboreham
Protect against Docker hanging trying to talk to a non-existent plugin
bc79a91 
Remove the Unix socket from the filesystem before doing volume
operations, if the plugin is not running.
@bboreham bboreham added this to the 1.5.2 milestone May 12, 2016
@awh awh merged commit 78672db into 1.5 May 18, 2016
@awh awh deleted the issues/2286-hang-torpedoes branch May 18, 2016 09:27
@awh awh mentioned this pull request May 18, 2016
Closed
@bboreham bboreham mentioned this pull request Jun 17, 2016
Merged
rade added a commit that referenced this pull request Jun 17, 2016
@rade
Merge pull request #2385 from weaveworks/2286-fix-check
61cb553 
Fix check before removing plugin sockets

Fixes the fix in #2292.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.2
Development

Successfully merging this pull request may close these issues.
2 participants
@bboreham @awh
0