8000 Publish weavedb container from release script by bboreham · Pull Request #2366 · weaveworks/weave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

Publish weavedb container from release script #2366

Merged
merged 1 commit into from
Jun 16, 2016

Conversation

bboreham
Copy link
Contributor

Fixes #2189

Note that the weavedb image will not be pushed by the CI build, to address the point at #2189 (comment)

@bboreham bboreham added this to the 1.6.0 milestone Jun 13, 2016
@@ -172,7 +172,7 @@ publish() {

if [ "$RELEASE_TYPE" = 'PRERELEASE' ] ; then
echo "== Tagging and pushing images on docker hub as user $DOCKERHUB_USER"
make UPDATE_LATEST=$UPDATE_LATEST SUDO=$SUDO WEAVE_VERSION=$VERSION DOCKERHUB_USER=$DOCKERHUB_USER publish
make PUBLISH_WEAVEDB=$UPDATE_LATEST UPDATE_LATEST=$UPDATE_LATEST SUDO=$SUDO WEAVE_VERSION=$VERSION DOCKERHUB_USER=$DOCKERHUB_USER publish

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

@awh
Copy link
Contributor
awh commented Jun 14, 2016

Also, not sure that PUBLISH_WEAVEDB=$UPDATE_LATEST makes a huge amount of sense. Perhaps we should rename the UPDATE_LATEST variable at the top of publish() to IS_MAINLINE now

@bboreham bboreham force-pushed the issues/2189-publish-weavedb branch from 4943614 to 2face0f Compare June 15, 2016 14:51
@bboreham bboreham assigned awh and unassigned bboreham Jun 15, 2016
@awh awh merged commit c6a777c into master Jun 16, 2016
@awh awh deleted the issues/2189-publish-weavedb branch June 16, 2016 10:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0