8000 Provide multicast isolation with in-container-netns iptables rules by awh · Pull Request #2386 · weaveworks/weave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

Provide multicast isolation with in-container-netns iptables rules #2386

Merged
merged 2 commits into from
Jul 12, 2016
Merged

Provide multicast isolation with in-container-netns iptables rules #2386

merged 2 commits into from
Jul 12, 2016

Conversation

awh
Copy link
Contributor
@awh awh commented Jun 17, 2016

Fixes #354.

@awh awh assigned rade Jun 17, 2016
@awh awh changed the title Issues/354 multicast isolation Provide multicast isolation with in-container-netns iptables rules Jun 17, 2016
@awh
Copy link
Contributor Author
awh commented Jun 17, 2016

I've only tested this cursorily; looking for initial feedback.

@rade rade removed their assignment Jun 17, 2016
@awh awh added this to the 1.7.0 milestone Jun 17, 2016
rade
rade reviewed Jun 21, 2016
View reviewed changes
net/veth.go
ps := strings.Split(rule, " ")
if len(ps) == 10 &&
ps[0] == "-A" && ps[2] == "-s" && ps[4] == "-d" && ps[5] == "224.0.0.0/4" &&
ps[6] == "-i" && ps[7] == ifName && ps[8] == "-j" && ps[9] == "ACCEPT" {

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

@awh
Copy link
Contributor Author
awh commented Jun 22, 2016

I have tested this manually - ready to merge IMO.

@awh awh assigned brb Jun 22, 2016
@rade rade modified the milestone: 1.8.0 Jul 1, 2016
@awh
Copy link
Contributor Author
awh commented Jul 12, 2016

Can you look at this @rade? - it's ready to merge IMO - Martynas is busy with the netns stuff atm...

@rade rade assigned rade and unassigned brb Jul 12, 2016
@rade rade merged commit d9c998b into master Jul 12, 2016
@rade rade added this to the 1.7.0 milestone Sep 23, 2016
@bboreham bboreham deleted the issues/354-multicast-isolation branch November 9, 2016 17:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rade rade

Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@awh @rade @brb
0