This repository was archived by the owner on Jun 20, 2024. It is now read-only.
refactor: restore grouping of functions in script #2439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent(ish) changes placed functions in the wrong sections. Fix that and label the sections more clearly.
|
I've put this in 1.6 since it's the kind of change that would otherwise cause continued merge headaches. Note that github does a rather mediocre job of showing what has actually happened here, which is simply moving some functions and adding some section heading comments. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent(ish) changes placed functions in the wrong sections. Fix that and label the sections more clearly.