This repository was archived by the owner on Jun 20, 2024. It is now read-only.
CNI plugin assigns an IP to the bridge by itself #2471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to call `weave expose` before use.
|
LGTM |
|
We do still need the fuller When a pod contacts a service on another node, it will start the conversation sending to the service address, which will be DNAT-ted to a node's real IP address. When the packet arrives at that host, it will arrive on the underlay network interface, and be dropped as a martian. So, we need the masquerade rules on the source host, so when the packet leaves the Weave network it changes its return address to the underlay IP address of the source host. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to call(see below) This simplifies set-up for Kubernetes, etc.weave exposebefore use.It only does if the config doesn't specify any routes or gateway, which may be too restrictive, but I guess we can wait for customer feedback.
CC @abuehrle for review of doc change