Switch CircleCI build VM to 14.04 #2491
Conversation
|
This is not the first time that joffrey/docker-py tests fail. In the past we fixed things w/o pinning. Given that the purpose of the tests is to check that the proxy is faithfully handling all docker traffic - regardless of version - I rather think pinning is a bad idea. |
4701131 to
bea258f
Compare
|
The pinning to 1.8.1 is required because the latest version of joffrey/docker-py tests requires 1.24 Docker API (=> 1.12.x Docker). Unfortunately, 1.12.x Docker is very unreliable and hangs from time to time during a run of the smoke tests. I've created a separate issue for switching back to joffrey/docker-py:latest and 1.12.1 Docker: #2499 |
@brb That is a bug in docker-py. The docker-py tests are annotated with version information, so only tests for the right version should be run. We should not be pinning the joffrey/docker-py image. |
| @@ -52,7 +52,7 @@ following command on any peer: | |||
| weave status ipam | |||
|
|
|||
| This command displays the peer names and nicknames, absolute quantity/percentage of allocation | |||
| range managed by peer and also identifies the names of unreachable peers. If you are satisifed | |||
| range managed by peer and also identifies the names of unreachable peers. If you are satisfied | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Hmm. The docker-py tests really ought to work out the server version by themselves. Alas I cannot find any code in docker-py that actually does that. I was convinced we had run into this sort of problem before, but have not been able to find an issue/pr in weave or docker-py for it, so I must have been imagining it. I am perplexed what the purpose of the version annotations in the tests is when there is no way to actually run the tests with a version other than DEFAULT_DOCKER_API_VERSION, which is set to 1.24 in the latest docker-py. |
0f3cadc to
aee35b3
Compare
As it is already installed on CircleCI 14.04 build VMs
Otherwise "go get -tags netgo" fails with the permission denied error.
The latest image requires 1.12.x dockerd.
The 14.04 VM includes go1.6 which uses
vendor/.