8000 skip failing docker_py integration tests by murali-reddy · Pull Request #3682 · weaveworks/weave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

skip failing docker_py integration tests #3682

Closed
wants to merge 1 commit into from
Closed

skip failing docker_py integration tests #3682

wants to merge 1 commit into from

Conversation

murali-reddy
Copy link
Contributor

disable test 602_proxy_docker_py_test.sh which is failing in CI

see #3680 for more details.

@rade
Copy link
Member
rade commented Aug 5, 2019

How do you know that the tested functionality isn't in fact broken?

@murali-reddy
Copy link
Contributor Author

There is no functional changes in weave related to docker proxy. Proxy tests are failing suddenly both on master and stable 2.5 branches. I can not figure but some thing in environment changed though docker version and docker-py is pinned to a specific version.

This PR is just to let other PR's unblock. #3680 still need to be addressed.

@rade
Copy link
Member
rade commented Aug 6, 2019

There is no functional changes in weave related to docker proxy.

Right, but these are integration tests; by their nature they test functionality that cuts across components. So they may have caught a breakage elsewhere.

Have you conducted any manual testing of the proxy functionality?

@murali-reddy
Copy link
Contributor Author

Have you conducted any manual testing of the proxy functionality?

No. Will do.

@murali-reddy
Copy link
Contributor Author

Closing as #3689 fixed the issue

@bboreham bboreham added this to the n/a milestone Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
n/a
Development

Successfully merging this pull request may close these issues.
3 participants
@murali-reddy @rade @bboreham
0