This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Handle range wrap-around when checking for allocations #3708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36fba88 to
2d7a5a6
Compare
Ring wraps around at zero but Space doesn't know about this, so we have to normalise ranges coming out of Ring. In turn we may need to split one range into two, across the end of the Ring.
Turn some Sprint() calls into `%v` in the outer format string. Remove one debug log line on duplicate token, since that info is already logged. Add an Info log line when we accept another peer's token, since that should be a rare event, and it's important if we've made a mistake.
2d7a5a6 to
44f9195
Compare
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3693
Ringwraps around at zero butSpacedoesn't know about this, so we have to normalise ranges coming out ofRing. In turn we may need to split one range into two, across the end of theRing.The unit tests passed because they are calling
distanceinside the Ring package, which understands the wrap-around. We may want to make them more realistic, maybe move up toipampackage.Also log the event when we do accept another peer's token, since that should be a rare event, and it's important if we've made a mistake.