8000 refactor: import dep generation for defer module with async module deps by hai-x · Pull Request #19691 · webpack/webpack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: import dep generation for defer module with async module deps #19691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

refactor: import dep generation for defer module with async module deps #19691

merged 1 commit into from
Jul 14, 2025

Conversation

hai-x
Copy link
Member
@hai-x hai-x commented Jul 12, 2025

What kind of change does this PR introduce?

Try to align with the logic about infering all async module by incomingConnections in InferAsyncModulesPlugin.

Did you add tests for your changes?

Existing

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

No

@hai-x hai-x changed the title refactor: import dependency generation for defer module with async de… refactor: import dep generation for defer module with async module deps Jul 12, 2025
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Jul 12, 2025

CodSpeed Performance Report

Merging #19691 will degrade performances by 95.33%

Comparing refactor-defer-import-dep (6b4ac0c) with main (ad1e3b4)

Summary

⚡ 1 improvements
❌ 84 regressions
✅ 48 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ benchmark "cache-filesystem", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 10.7 ms 228.8 ms -95.33%
❌ benchmark "devtool-source-map", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 11.8 ms 43 ms -72.47%
❌ benchmark "future-defaults", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 11.7 ms 40.5 ms -71.23%
❌ benchmark "many-chunks-commonjs", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 12 ms 52.3 ms -77.07%
⚡ benchmark "many-modules-commonjs", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 52.4 ms 9.9 ms ×5.3
❌ benchmark "many-modules-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 11.2 ms 50.3 ms -77.81%
❌ benchmark "minimal", scenario '{"name":"mode-development","mode":"development"}' 24.3 ms 30.8 ms -20.94%
❌ md4 buffer benchmark (size: 10000) 72.9 µs 114.7 µs -36.4%
❌ md4 buffer benchmark (size: 120) 34.8 µs 76.5 µs -54.45%
❌ md4 buffer benchmark (size: 160) 34.9 µs 76.6 µs -54.48%
❌ md4 buffer benchmark (size: 16366) 97.3 µs 139 µs -30.01%
❌ md4 buffer benchmark (size: 16368) 97.4 µs 139 µs -29.95%
❌ md4 buffer benchmark (size: 16370) 97.3 µs 139.2 µs -30.05%
❌ md4 buffer benchmark (size: 2) 35 µs 76.8 µs -54.38%
❌ md4 buffer benchmark (size: 20) 32.6 µs 76.8 µs -57.5%
❌ md4 buffer benchmark (size: 200) 35.1 µs 76.8 µs -54.26%
❌ md4 buffer benchmark (size: 2000) 40.7 µs 82.3 µs -50.58%
❌ md4 buffer benchmark (size: 20000) 111.5 µs 153.2 µs -27.24%
❌ md4 buffer benchmark (size: 2002) 40.7 µs 82.4 µs -50.64%
❌ md4 buffer benchmark (size: 40) 32.5 µs 74.1 µs -56.14%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@alexander-akait alexander-akait merged commit e251891 into main Jul 14, 2025
42 of 44 checks passed
@alexander-akait alexander-akait deleted the refactor-defer-import-dep branch July 14, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hai-x @alexander-akait
0