agent: run threads safely #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doron-cohen
suggested changes
Dec 11, 2019
talker_agent/talker.py
Outdated
|
|
||
|
|
||
| class SafeThread(threading.Thread): | ||
| def __init__(self, group=None, target=None, name=None, args=(), kwargs=None, *, daemon=None): |
There was a problem hiding this comment.
let's make the name argument non optional.
There was a problem hiding this comment.
also I think all arguments should be keyword arguments to avoid confusion
talker_agent/talker.py
Outdated
| def run(self): | global first_exception_info | |
| try: | ||
| if self._target: |
talker_agent/talker.py
Outdated
| self._target(*self._args, **self._kwargs) | ||
| except: | ||
| exc_info = sys.exc_info() | ||
| logger.debug("exception in '%s'", self.name, exc_info=exc_info) |
There was a problem hiding this comment.
better log this to info so it will get to the machine's syslog
talker_agent/talker.py
Outdated
| exc_info = sys.exc_info() | ||
| logger.debug("exception in '%s'", self.name, exc_info=exc_info) | ||
| if not first_exception_info: | ||
| first_exception_info = sys.exc_info() |
There was a problem hiding this comment.
shouldn't this be wrapped with a lock?
8909732 to
952db29
Compare
doron-cohen
reviewed
Dec 19, 2019
doron-cohen
approved these changes
Dec 22, 2019
CHANGELOG.md
Outdated
| @@ -5,6 +5,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [Unreleased] | |||
| ### Changed | |||
| - make all agent threads thread-safe | |||
There was a problem hiding this comment.
not really a user facing change. maybe a bug fix
9bde5b6 to
b26b5f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.