8000 Fix Docker Build when USE_EDGE=true by jtickle · Pull Request #1114 · wekan/wekan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Docker Build when USE_EDGE=true #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2017
Merged

Fix Docker Build when USE_EDGE=true #1114

merged 2 commits into from
Jul 11, 2017

Conversation

jtickle
Copy link
Contributor
@jtickle jtickle commented Jul 5, 2017

This kind-of fixes #1110, but only if you build your Dockerfile with USE_EDGE=true. The wekanteam/wekan:latest on Docker Hub still has the double-slash bug.

Note that the changes are: fixed a path from /home/wekan/packages to /home/wekan/.meteor/packages; and commented out the 'api.versionsFrom(...)' code in package.js for both kadira-flow-router and meteor-useraccounts-core. I know nothing about Meteor so there may be a better way to fix this, but the change got it to where my Dockerfile would build, and now there is no double-slash issue.


This change is Reviewable

@CLAassistant
Copy link
CLAassistant commented Jul 5, 2017

CLA assistant check
All committers have signed the CLA.

xet7 added a commit to KanRule/flow-router that referenced this pull request Jul 5, 2017
@xet7 xet7 merged commit d461580 into wekan:devel Jul 11, 2017
@xet7
Copy link
Member
xet7 commented Jul 11, 2017

@jtickle

Please test latest wekanteam docker image after it's built, does this really fix it for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker Deployment - double-slash with ROOT_URL
3 participants
0