8000 Dockerfile fix for local packages (Take 2) by Serubin · Pull Request #959 · wekan/wekan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Dockerfile fix for local packages (Take 2) #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

Serubin
Copy link
Contributor
@Serubin Serubin commented Mar 30, 2017

This hasn't been tested, I don't have a way to test this currently

Can someone please confirm that this works as expected BEFORE being merged in?

This should fix the local flow-router dependency.


This change is Reviewable

@stephenmoloney
Copy link
Contributor

As previously discussed, you cannot run the command source like that inside a dockerfile.

This will not work.

https://travis-ci.org/wekan/wekan#L4565

@Serubin
Copy link
Contributor Author
Serubin commented Mar 30, 2017

@stephenmoloney Can you please offer a suggestion on an alternative way to add an environment variable?

@stephenmoloney
Copy link
Contributor

@Serubin
I did in this post

I even tried those changes for the ENV

It doesn't work.

I would focus on #957 for now to get the Dockerfile up and running.

@Serubin
Copy link
Contributor Author
Serubin commented Mar 30, 2017

I see what's going on now. Have we looked into options like this? npm/npm#9863

@stephenmoloney
Copy link
Contributor

The closest issue is documented here

We need to upgrade meteor, various dependencies and node js.

That is ongoing now at #957

@Serubin
Copy link
Contributor Author
Serubin commented Mar 30, 2017

Understood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0