8000 fix: process hang due to theme source endless loop by sentialx · Pull Request #469 · wexond/browser-base · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 4, 2023. It is now read-only.

fix: process hang due to theme source endless loop #469

Merged
merged 1 commit into from
May 6, 2020
Merged

fix: process hang due to theme source endless loop #469

merged 1 commit into from
May 6, 2020

Conversation

sentialx
Copy link
Member
@sentialx sentialx commented May 6, 2020

Description of Change

The nativeTheme.themeSource was being updated on nativeTheme updated event, but also changing themeSource caused updated event to fire, thus making the process completely hang on macOS.

Closes #455

Checklist

  • PR description included
  • PR title follows semantic commit guidelines
  • PR release notes describe the change, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed process hanging up due to endless loop when changing themeSource on macOS.

@sentialx sentialx merged commit c89363e into master May 6, 2020
@sentialx sentialx deleted the fix-theme-source-loop branch May 6, 2020 13:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version 5beta1 hang up due to CPU consumption
1 participant
@sentialx
0