Verify domain is not empty after "domain to ASCII" #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The empty host is not allowed in special non-"file" URLs, but `domain to ASCII` result can be the empty string, even if the input is not empty, for example: * the input consists entirely of IDNA ignored code points; * the input is `xn--`. The `domain to ASCII` do not fail when it is called from `host parser`, because `VerifyDnsLength` is false. So we need additional check after it.
rmisev
added a commit
to rmisev/web-platform-tests
that referenced
this pull request
May 6, 2020
See whatwg/url#497 for context.
|
See also #438. I think we should add this check in https://url.spec.whatwg.org/#concept-domain-to-ascii so that a domain also cannot be valid if it ends up empty. |
|
Hmm, in the valid domain check https://whatpr.org/url/497.html#valid-domain the |
|
Ah fair, I guess I'd still like to include this check there, but I'd be okay with making it conditional upon beStrict. At some point we have to revise the general ToASCII operation and it would be good if all the weirdness was consolidated to make that easier. |
|
OK, changed. |
annevk
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 7, 2020
See whatwg/url#497 for context.
TRowbotham
added a commit
to TRowbotham/URL-Parser
that referenced
this pull request
May 15, 2020
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 15, 2020
…st, a=testonly Automatic update from web-platform-tests URL: test IDNA ignored code points in host See whatwg/url#497 for context. -- wpt-commits: e9a106175a02a192a7239f42a94235fbe0f0c7a3 wpt-pr: 23432
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
May 15, 2020
…st, a=testonly Automatic update from web-platform-tests URL: test IDNA ignored code points in host See whatwg/url#497 for context. -- wpt-commits: e9a106175a02a192a7239f42a94235fbe0f0c7a3 wpt-pr: 23432
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 20, 2020
…st, a=testonly Automatic update from web-platform-tests URL: test IDNA ignored code points in host See whatwg/url#497 for context. -- wpt-commits: e9a106175a02a192a7239f42a94235fbe0f0c7a3 wpt-pr: 23432
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
May 20, 2020
…st, a=testonly Automatic update from web-platform-tests URL: test IDNA ignored code points in host See whatwg/url#497 for context. -- wpt-commits: e9a106175a02a192a7239f42a94235fbe0f0c7a3 wpt-pr: 23432
rmisev
added a commit
to upa-url/upa
that referenced
this pull request
May 24, 2020
djc
added a commit
to servo/rust-url
that referenced
this pull request
Aug 18, 2020
Per the change in whatwg/url#497.
targos
added a commit
to targos/node
that referenced
this pull request
Sep 8, 2020
nodejs-github-bot
pushed a commit
to nodejs/node
that referenced
this pull request
Sep 16, 2020
Port of whatwg/url#497 PR-URL: #33770 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Port of whatwg/url#497 PR-URL: nodejs#33770 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
annevk
added a commit
that referenced
this pull request
Dec 2, 2024
VerifyDnsLength will take care of it otherwise. (See #497 for additional context.)
annevk
added a commit
that referenced
this pull request
Dec 2, 2024
VerifyDnsLength will take care of it otherwise. (See #497 for additional context.)
bhearsum
pushed a commit
to mozilla-releng/staging-firefox
that referenced
this pull request
May 1, 2025
…st, a=testonly Automatic update from web-platform-tests URL: test IDNA ignored code points in host See whatwg/url#497 for context. -- wpt-commits: e9a106175a02a192a7239f42a94235fbe0f0c7a3 wpt-pr: 23432
bhearsum
pushed a commit
to mozilla-releng/staging-firefox
that referenced
this pull request
May 1, 2025
…st, a=testonly Automatic update from web-platform-tests URL: test IDNA ignored code points in host See whatwg/url#497 for context. -- wpt-commits: e9a106175a02a192a7239f42a94235fbe0f0c7a3 wpt-pr: 23432
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The empty host is not allowed in special non-"file" URLs, but
domain to ASCIIresult can be the empty string, even if theinput is not empty, for example:
xn--.The
domain to ASCIIdo not fail when it is called fromhost parser,because
VerifyDnsLengthis false.So we need additional check after it.
An interesting case is with file URLS, as empty host is allowed. But most
browsers report failure as well. I tested URLs with the
U+00ADpercent encoded in host:
file://%C2%AD/pfile:///phttp://%C2%AD/pNote. To find more IDNA ignored code points refer to IDNA Mapping Table:
https://unicode.org/reports/tr46/#IDNA_Mapping_Table
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff