8000 Make port state override return failure more for URLPattern by annevk · Pull Request #866 · whatwg/url · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make port state override return failure more for URLPattern #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

Make port state override return failure more for URLPattern #866

merged 1 commit into from
Mar 24, 2025

Conversation

annevk
Copy link
Member
@annevk annevk commented Mar 20, 2025 •
edited by pr-preview bot
Loading

In particular for inputs that do not start with an ASCII digit.

Tests: web-platform-tests/wpt#51505.

This fixes whatwg/urlpattern#266.

(See WHATWG Working Mode: Changes for more details.)

Preview | Diff

@annevk
Make port state override return failure more for URLPattern
cdd32a1 < 8000 /code> 
In particular for inputs that do not start with an ASCII digit.

Tests: web-platform-tests/wpt#51505.

This fixes whatwg/urlpattern#266.
@annevk
Copy link
Member Author
annevk commented Mar 20, 2025 •
edited
Loading

cc @anonrig @sisidovski @shannonbooth

@annevk annevk mentioned this pull request Mar 21, 2025
Closed
sisidovski
sisidovski approved these changes Mar 21, 2025
View reviewed changes
Copy link
@sisidovski sisidovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the discussion in whatwg/urlpattern#266, I think this change is reasonable.

shannonbooth
shannonbooth approved these changes Mar 22, 2025
View reviewed changes
Copy link
Member
@shannonbooth shannonbooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied this patch, along with the WPT tests as part of this change, and all of them pass on my implementation. Looks good to me!

image

@annevk annevk merged commit cc8b776 into main Mar 24, 2025
2 checks passed
@annevk annevk deleted the annevk/port-state-override branch March 24, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sisidovski sisidovski sisidovski approved these changes

@shannonbooth shannonbooth shannonbooth approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port canonicalization does not return failure for port of 'invalid80'
3 participants
@annevk @sisidovski @shannonbooth
0