8000 Editorial: Use code unit less than algorithm for URLSearchParams sort by shannonbooth · Pull Request #872 · whatwg/url · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Editorial: Use code unit less than algorithm for URLSearchParams sort #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 12, 2025
Merged

Editorial: Use code unit less than algorithm for URLSearchParams sort #872

merged 3 commits into from
May 12, 2025

Conversation

shannonbooth
Copy link
Member
@shannonbooth shannonbooth commented May 12, 2025 •
edited by pr-preview bot
Loading

I noticed this algorithm in the infra spec, and I believe this is what all engines already do for the sort.

Hopefully not mistaken!

Preview | Diff

annevk
annevk reviewed May 12, 2025
View reviewed changes
Copy link
Member
@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this. We want to reference https://infra.spec.whatwg.org/#list-sort-in-ascending-order here as well and update the wording to follow that (similar to the example).

@shannonbooth
Copy link
Member Author

Thanks for noticing this. We want to reference infra.spec.whatwg.org#list-sort-in-ascending-order here as well and update the wording to follow that (similar to the example).

Thanks! Made that edit, though I'm not 100% sure I got the tuple part of this completely correct in proper spec wording

annevk
annevk reviewed May 12, 2025
View reviewed changes
Copy link
Member
@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording looks correct, but we need to start with something like:

Set this's list to the result of sorting in ...

as we are now allocating a new list instead of mutating in place.

@annevk annevk closed this May 12, 2025
@annevk annevk reopened this May 12, 2025
@annevk annevk merged commit 59979a1 into whatwg:main May 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shannonbooth @annevk
0