Support filtering variant dependencies from build reqs #1
Conversation
There was a problem hiding this comment.
Code looks like it'll work as advertised, only some minor comments.
variant_x86_64;
'x86_64' in variants
My one more substantial comment is that the semantics of this syntax may need to become more well-defined. This intuitively feels circular: depend on the x86-64 plugin if x86-64 is in the environment (which perhaps we can only know if we have the x86-64 plugin already?).
| @@ -36,6 +36,7 @@ dynamic = ["version"] | |||
| dependencies = [ | |||
| "packaging >= 19.1", | |||
| "pyproject_hooks", | |||
| "variantlib @ https://github.com/wheelnext/variantlib/archive/main.tar.gz", | |||
There was a problem hiding this comment.
Are these @ https://github.com/wheelnext still easy enough to work with? It seems like a uv workspace with a collection of all these forks of packages as editable is going to be needed at some point.
There was a problem hiding this comment.
"Easy" is not a word I'd use. It's quite annoying for development work (I basically uv pip install -e ... this package, then uv pip install -e ... variantlib to have it return to the development copy). However, it makes "release" installs easier when variantlib is not yet on the official index.
| self, | ||
| dependencies: set[str], | ||
| config_settings: ConfigSettings | None = None, | ||
| ) -> set[str]: |
There was a problem hiding this comment.
This logic is probably right; a docstring or some code comments will be helpful before merging though. Just from reading the code it's hard to tell, and navigating to evaluate_variant_requirements loses context.
There was a problem hiding this comment.
Capturing in filter_variants that this is demo-only and specific to pypa/build and probably not quite suitable for a final design will be useful here - at least for me, it's the kind of thing I'd forget over time.
This is a slightly different case than runtime dependencies. Here |
xref: wheelnext/variantlib#32
The idea is that e.g. in numpy we can do:
And
buildusesvariantlibto preprocess the'x86_64' in variantsspecifier, so that uv/pip can handle the resulting deps. Not saying the design is neat, but should be good enough for a demo.