Add support for zooming with multiple fingers 🤘 #351
Conversation
|
|
✅ Deploy Preview for zoom-image-library ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
Adds support for zooming with more than two touch points by handling any multi-finger touch events and updating package sizes and version metadata.
- Expand touch handling from exactly two touches to any multi-touch scenario, using the first two touch points for pinch calculations
- Update reported gzipped sizes in
size.jsonfor several frameworks and fix ordering in the Angular section - Bump the minor version in the changeset to reflect the new feature
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| size.json | Updated gzipped size values and adjusted key ordering for Angular |
| packages/core/src/createZoomImageWheel.ts | Changed pinch logic to handle more than two touches, slicing first two |
| .changeset/hungry-friends-scream.md | Bumped minor version and added feature description |
Comments suppressed due to low confidence (3)
packages/core/src/createZoomImageWheel.ts:344
- [nitpick] You’re calling
event.preventDefault()here for single-touch and again in the multi-touch block—consider consolidating these preventDefault calls or clearly separating their conditions to improve readability.
if (finalOptions.shouldZoomOnSingleTouch()) event.preventDefault()
packages/core/src/createZoomImageWheel.ts:345
- [nitpick] Add a comment explaining that you only use the first two touch points for pinch calculations when more than two fingers are down, so future readers understand the slice behavior.
if (event.touches.length > 1) {
packages/core/src/createZoomImageWheel.ts:343
- We should add unit or integration tests to verify the new multi-touch behavior (e.g., three or more touches where only the first two are used) to prevent regressions.
function _handleTouchMove(event: TouchEvent) {
| "ZoomImageHoverService": "4.07 KB", | ||
| "ZoomImageMoveService": "4.07 KB", | ||
| "ZoomImageWheelService": "4.06 KB" | ||
| "ZoomImageClickService": "4.07 KB", |
There was a problem hiding this comment.
[nitpick] The key order in the Angular section now is Hover, Move, Click, Wheel—consider reordering to Click, Hover, Move, Wheel (or alphabetically) for consistency with other sections.
Copilot uses AI. Check for mistakes.
No description provided.