8000 feat: only update cache-file for installed apps by silentJET85 · Pull Request #1419 · wimpysworld/deb-get · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: only update cache-file for installed apps #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: only update cache-file for installed apps #1419

wants to merge 1 commit into from

Conversation

silentJET85
Copy link
Contributor

This PR will make it so that deb-get update will only update the cache file for apps that are already installed.
Unless I'm overlooking something, there doesn't seem to be any need to have the cache file for non-installed apps. When installing an app, it will still be downloaded if needed.

This should significantly reduce the amount that the Github API is being called for the average user, at least partially solving #757. As well as just speeding up the deb-get update process overall.

This should also have the side-benefit of reducing the errors shown for apps that are not installed, as mentioned in #964.

@GideonBear
Copy link
Contributor

Applied the patch on my system, no problems so far. Good idea!
One thing: it does hide errors for apps that are not installed, which could also hide the errors from maintainers; it's probably best to catch those errors early. Maybe we could set up a workflow to run daily that updates the cache for all packages (or maybe even installs all packages)?

@silentJET85
Copy link
Contributor Author

I've been tossing around the idea of making a local script to do something similar in virtual machines on a spare computer. Maybe even having a separate VM for each supported release (bookworm, trixie, jammy, noble, etc) and testing every package in each, to be thorough.

But the Github Workflow idea is probably better and less maintenance. My only worry would be about exceeding the allotted minutes if we install every package. (Not sure what tier they're on.) Although installing them all would be helpful in finding breakages early.

Perhaps just updating the cache daily, and doing full installs only weekly or monthly would be sufficient. Or something like that.

@GideonBear
Copy link
Contributor
GideonBear commented Apr 25, 2025 •
edited
Loading

Agreed that it should do it on all supported releases, but unfortunately it doesn't look like GitHub Actions has them all, and I don't think it's a good idea to run it in containers, since packages might depend on things like graphical libraries, etc. to be available. nvm that doesn't make any sense I think. GitHub Actions is a container/vm itself. So it's probably possible.
Also note that installing the same version of a package twice is absolutely pointless (right?), so we should be able to cache the version that was last tested, and only test new versions of packages; we could probably run it daily if we do it that way.

@silentJET85 silentJET85 mentioned this pull request May 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silentJET85 @GideonBear
0