feat(firefox): add Debian support #1435
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1328
This PR adds Debian support for all of the Firefox packages.
(Note: Most of these use the
GPG_KEY_IDvariable, which currently doesn't work in Sid, Trixie and Plucky. #1434 should fix that.)firefox:
Switches from the PPA to Mozilla's apt repository.
Edited
ARCHS_SUPPORTEDvariable to remove the extra Archs that aren't supported by Mozilla's repo.Looking through the PPA page, it looks like they've only been building for amd64 and arm64 for a while now. So we aren't actually losing anything by switching.
#1427 would need to be merged in order for this to install properly in Ubuntu Jammy and up. But this is also true of the current firefox package.
firefox-beta, firefox-nightly, firefox-devedition:
Edited
ARCHS_SUPPORTEDvariable to remove the extra Archs that aren't supported by Mozilla's repo. The other Archs were only applicable to the PPA, which these packages never used anyway.Removed
CODENAMES_SUPPORTEDvariable, so that all codenames are supported. I have tested that they all install and run in Buster and up, and Focal and up.firefox-esr:
Added Mozilla's apt repo for AMD64 machines. Their repo doesn't have an ARM64 version for firefox-esr, like they do for the other Firefox editions. So for ARM, the PPA will continue to be used.
If desired, I can replace the
PPA="ppa:mozillateam/ppa"line with(It's not clear if it was decided to allow splitting methods or not, Since #1295 was merged instead of #1309.
I don't know if that was an intentional decision or perhaps just the first of the two PRs that Martin happened to encounter.)