We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving this here since Github didn't allow properly reverting #15.
Sorry, something went wrong.
feat: fix up authors and keep GPL
570badd
cc @GreatNovaDragon
So @AkechiShiro suggested this license: https://commission.europa.eu/content/european-union-public-licence_en (full license text).
This license is OSI-approved. However, the FSF classifies it as non-compatible with the GPL because it technically allows sublicensing and relicensing the work under a GPLv3. In our case, this would not be possible due to the CLA, but I don't see the advantages of the EUPL right now.
Could we then move from GPLv3 to AGPLv3 ? @oskardotglobal
@AkechiShiro The only difference between the AGPLv3 and the GPLv3 is the source distribution clause when distributing it over a network. Since WinApps is distributed as it's source, I don't see why this would matter.
Hmm I thought it would be useful if someone tries to make a payed service with winapps without redistributing the source, nor providing the license we use, and wouldn't need to provide their modifications as source code.
https://opensource.stackexchange.com/questions/5041/of-the-differences-between-the-gplv3-and-the-agplv3-texts-what-to-make-of-them#5054
Well, the changed Section 13 explicitly talks about a server, I don't see how one would make a paid service out of WinApps.
Reapply "Merge pull request #15 from winapps-org/add-contribution-gui…
3cb2e18
…delines" This reverts commit 2dd0980.
Merge branch 'add-contribution-guidelines'
99eeac4
Ok, this is now ready for review
@oskardotglobal So you don't see how it would be possible to serve Winapps through an xrdp server or KasmVNC ?
Should I poc this real quick?
Well then you would be providing Windows VMs as a service, not WinApps, would you not? We can't really stop someone from just selling VMs with RDP enabled and then "recommending" their users to use WinApps. But you're probably right, I can change this to an AGPLv3 if you want.
feat: relicense to AGPLv3
3d67406
I would like if there is no objection from anyone that we'd use AGPLv3 @GreatNovaDragon
sure, agpl works for me
Can someone review?
@oskardotglobal can you rebase on main I see changes on CI and the setup script, this shouldn't be here.
Merge remote-tracking branch 'origin/main' into add-contribution-guid…
2d06aa2
…elines
60ef05a
The CI changes are just to ensure the license headers on all files.
I've created this matrix channel : https://matrix.to/#/#winapps:matrix.org feel free to join @oskardotglobal @LDprg @GreatNovaDragon
Update CODE_OF_CONDUCT.md
ad8b1cf
What is missing to merge this PR ?
Nothing that I know of
Maybe I'll open an documentation issue for the CI actions used, but I dont think there is anything else of concern
41a1450
Merge pull request #240 from winapps-org/add-contribution-guidelines
cccdf03
Resolve licensing issues
Hey @oskardotglobal and @LDprg could you join the Matrix/Element chat please ?
I would like to discuss about wayland support plans and I'm looking into this : https://github.com/elliotkillick/qvm-create-windows-qube
Hold on I'll have to unfuck my homeserver's federation first
AkechiShiro AkechiShiro approved these changes
novadragonDOTspace novadragonDOTspace approved these changes
Successfully merging this pull request may close these issues.