-
Notifications
You must be signed in to change notification settings - Fork 74
Spring boot to azure feign #699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested this yet but as first round review, please slim down the feign-core-9.4.0.jar
to be just like other test jars in the same folder.
There also another comment for the test data path.
rules-reviewed/azure/springboot/tests/spring-boot-to-azure-feign.windup.test.xml
Outdated
Show resolved
Hide resolved
* Azure rule for read-only static content * Update rules-reviewed/azure/springboot/spring-boot-to-azure-static-content.windup.xml Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com> * Update rules-reviewed/azure/springboot/spring-boot-to-azure-static-content.windup.xml Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are some technology rules to be fixed
rules-reviewed/technology-usage/embedded-framework-technology-usage.windup.xml
Show resolved
Hide resolved
@mrizzi I'm getting confused now with all the renumbering of the technology rules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested some changes to restore previously committed rules and tests.
rules-reviewed/technology-usage/embedded-framework-technology-usage.windup.xml
Show resolved
Hide resolved
rules-reviewed/technology-usage/tests/embedded-framework-technology-usage.windup.test.xml
Show resolved
Hide resolved
rules-reviewed/technology-usage/tests/embedded-framework-technology-usage.windup.test.xml
Show resolved
Hide resolved
Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com>
…ology-usage.windup.test.xml Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com>
* Azure rule for clear password * Fix the tags
…al/windup-rulesets into agoncal-spring-boot-to-azure-feign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the end I think everything has been sorted out so thanks @agoncal for the contribution 👍
No description provided.