EAP to Azure AppService - Look for datasource drivers in config files #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-brophy
requested changes
Jun 29, 2022
| <rules> | ||
| <rule id="eap-to-azure-appservice-datasource-driver-01000"> | ||
| <when> | ||
| <xmlfile matches="//driver" /> |
There was a problem hiding this comment.
I think this is too broad a filter. Searching for a <driver> element will find non-database related xml elements too, for instance libvirt disk config xml has a driver element. Maybe we can add a pattern for the acceptable contents of the element ( eg postgresql|jdbc|h2|mongodb etc)?
…ithub.com/dfuenzalida/windup-rulesets into dfuenzalida-eap-in-azure-appservice-datasource-driver
…re-appservice-datasource-driver Merge changes by PhilipCattanach in EAP in Azure AppService datasource driver rule
m-brophy
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look for database drivers in configuration files, since these need a script to be installed during application startup