8000 [WINDUPRULE-896] Jakarta servlet related rules by jmle · Pull Request #785 · windup/windup-rulesets · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[WINDUPRULE-896] Jakarta servlet related rules #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 11, 2023
Merged

[WINDUPRULE-896] Jakarta servlet related rules #785

merged 5 commits into from
Jan 11, 2023

Conversation

jmle
Copy link
Contributor
@jmle jmle commented Nov 29, 2022

@PhilipCattanach
Copy link
Contributor

@jmle Feedback provided on the associated Jira

@PhilipCattanach
Copy link
Contributor

HI @jmle - Nearly there, Just a couple of minor changes please.
Rule 00071 and 00072 can you add the signature of the methods removed
Rule 00102 has the method name missing from the title
Rule 00112 please provide the signature of the new method in the message
Please change any rules with 2 SP to 3 SP
See section A3.2 in this guide about the SP values
https://access.redhat.com/documentation/en-us/migration_toolkit_for_applications/6.0/html/cli_guide/reference_material

@PhilipCattanach
Copy link
Contributor

@jmle - There are still some loose ends to tidy up on this Ruleset (see my comments immediately above).
Also This article has now been published https://access.redhat.com/articles/6980265#servlet so please can you use this for the links

@PhilipCattanach PhilipCattanach merged commit 66405db into windup:master Jan 11, 2023
@mrizzi mrizzi added auto-backport Set the PR for being backported auto-backport-to-releases/6.1.z Backport this issue to releases/6.1.z branch labels Feb 23, 2023
@github-actions
Copy link

💔 All backports failed

Status Branch Result
❌ releases/6.1.z Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 785

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

mrizzi pushed a commit to mrizzi/windup-rulesets that referenced this pull request Feb 23, 2023
@jmle @PhilipCattanach @mrizzi
[WINDUPRULE-896] Jakarta servlet related rules (windup#785)
5fc00c6 
* [WINDUPRULE-896] Implement jakarta servlet rules

* [WINDUPRULE-896] Fix test

* [WINDUPRULE-896] Make rules more specific

* [WINDUPRULE-896] Adjust rule messages

* WINDUPRULE-896 minor corrections from PR review

Co-authored-by: PhilipCattanach <pcattana@redhat.com>
@mrizzi mrizzi mentioned this pull request Feb 23, 2023
Merged
mrizzi added a commit that referenced this pull request Feb 23, 2023
@mrizzi @jmle @PhilipCattanach
[WINDUPRULE-896] Jakarta servlet related rules (#785) (#878)
b72bd12 
* [WINDUPRULE-896] Implement jakarta servlet rules

* [WINDUPRULE-896] Fix test

* [WINDUPRULE-896] Make rules more specific

* [WINDUPRULE-896] Adjust rule messages

* WINDUPRULE-896 minor corrections from PR review

Co-authored-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Co-authored-by: PhilipCattanach <pcattana@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-backport Set the PR for being backported auto-backport-to-releases/6.1.z Backport this issue to releases/6.1.z branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmle @PhilipCattanach @mrizzi
0