8000 Winduprule-894 by m-brophy · Pull Request #800 · windup/windup-rulesets · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Winduprule-894 #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 14, 2022
Merged

Winduprule-894 #800

merged 8 commits into from
Dec 14, 2022

Conversation

m-brophy
Copy link
Contributor
@m-brophy m-brophy commented Dec 8, 2022 •
edited
Loading

https://issues.redhat.com/browse/WINDUPRULE-894

Migration to Jakarta Faces 4.0

@m-brophy m-brophy requested a review from jmle December 13, 2022 12:25
@PhilipCattanach
Copy link
Contributor

Well done @m-brophy lots of things to cover in this ruleset and the implementation is really good.
One question and one minor point.
Q: Why is the ruleset under eap8/eap6 rather than eap8/eap7 ?
Observation: It would be nice if the reference to jakarta.faces.application.ResourceHandler in the message for rule eap-faces-00008 is book ended with the ` character.

@m-brophy
Copy link
Contributor Author

I placed the rules in eap8/eap6 because that was the first supported migration path I encountered in the issue details doc https://docs.google.com/document/d/1uI9X0N74wsWFhGTI_37VsszNj04_KKM-tpSnz2B8b6Y

@m-brophy
Copy link
Contributor Author

markup altered in rule eap-faces-00008

@PhilipCattanach
Copy link
Contributor

Thanks @m-brophy
regarding the path - that's fine, thank you.
I'll retest the markup and merge to master as soon as the automated checks complete.

@PhilipCattanach PhilipCattanach merged commit 6488697 into windup:master Dec 14, 2022
@mrizzi mrizzi added auto-backport Set the PR for being backported auto-backport-to-releases/6.1.z Backport this issue to releases/6.1.z branch labels Dec 16, 2022
@github-actions github-actions bot mentioned this pull request Dec 16, 2022
Merged
github-actions bot pushed a commit that referenced this pull request Dec 16, 2022
@m-brophy
Winduprule-894 (#800)
5c789c8 
* WINDUPRULE-894: tests added

* added namespace data into rule and test

* eap8-faces rules

* Faces 4 JSP rule not working

* WINDUPRULE-894: identify a jsp file in rule

* WINDUPRULE-894: alter markup in rule message

(cherry picked from commit 6488697)
@github-actions
Copy link

💚 All backports created successfully

Status Branch Result
✅ releases/6.1.z

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

mrizzi pushed a commit that referenced this pull request Dec 16, 2022
@github-actions @m-brophy
Winduprule-894 (#800) (#828)
ad61fdc 
* WINDUPRULE-894: tests added

* added namespace data into rule and test

* eap8-faces rules

* Faces 4 JSP rule not working

* WINDUPRULE-894: identify a jsp file in rule

* WINDUPRULE-894: alter markup in rule message

(cherry picked from commit 6488697)

Co-authored-by: Mark Brophy <36955467+m-brophy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilipCattanach PhilipCattanach Awaiting requested review from PhilipCattanach

@jmle jmle Awaiting requested review from jmle

Assignees
No one assigned
Labels
auto-backport Set the PR for being backported auto-backport-to-releases/6.1.z Backport this issue to releases/6.1.z branch Ready to Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-brophy @PhilipCattanach @mrizzi
0