8000
[WINDUPRULE-941] Migration from hibernate-search 6.0 to 6.1 by jmle · Pull Request #844 · windup/windup-rulesets · GitHub
More Web Proxy on the site http://driver.im/
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @jmle - I have reviewed and tested the PR and overall it is good.
One minor change is required to the rule # 20 the word to is repeated within the highlighted text.
to `to
The thing that is missing are the rules for deprecated API's
We always create rules under the Migration Optional category to warn users of Deprecated APIs that will be deleted in a future release.
Hi Juanma,
When I was looking through the rules folders I noticed that we have some old hibernate rules in the hibernate rules folder.
However for more recent releases of EAP we have tended to put the Hibernate rules in the eap rules folders. For example eap7/eap71
Could I ask for 1 final change please and move this ruleset into the eap8/eap7 folder please?
Thanks
Hi @jmle
Rule hibernate-search-6.1-00020 still has the superfluous 'to' within it.
Rule hibernate-search-6.1-00040 please change the message from 'now API' to 'now an API'
Rules hibernate-search-6.1-00150 and hibernate-search-6.1-00160 I think a , rather than a - would read better
Rules hibernate-search-6.1-00170 and hibernate-search-6.1-00180 I think a , rather than a : would read better
Thanks,
Phil
* [WINDUPRULE-941] Migration from hibernate-search 6.0 to 6.1
* [WINDUPRULE-941] Add rules for deprecated usages
* WINDUPRULE-941 add link for rules related to deprecated API
* [WINDUPRULE-941] Move hibernate rules to eap migration path
* [WINDUPRULE-941] Refactor test artifact info
* [WINDUPRULE-941] Fix typos
* WINDUPRULE-941 minor message punctuation changes to 2 rules related to deprecated components for consistency
---------
Co-authored-by: PhilipCattanach <pcattana@redhat.com>
(cherry picked from commit e4c583e)
)
* [WINDUPRULE-941] Migration from hibernate-search 6.0 to 6.1
* [WINDUPRULE-941] Add rules for deprecated usages
* WINDUPRULE-941 add link for rules related to deprecated API
* [WINDUPRULE-941] Move hibernate rules to eap migration path
* [WINDUPRULE-941] Refactor test artifact info
* [WINDUPRULE-941] Fix typos
* WINDUPRULE-941 minor message punctuation changes to 2 rules related to deprecated components for consistency
---------
Co-authored-by: PhilipCattanach <pcattana@redhat.com>
(cherry picked from commit e4c583e)
Co-authored-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Jira ticket.