[WINDUPRULE-899] Ruleset for hibernate orm 6.0 migration #853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrizzi
requested changes
Feb 7, 2023
There was a problem hiding this comment.
The ruleset has two targets and in the past this created a kind of confusion on where to put such rulesets.
Lately, when JBoss EAP is one of the targets, it's fine to consider these rules as JBoss EAP migration rules first and foremost (e.g. Hibernate 5 rules https://github.com/windup/windup-rulesets/blob/master/rules/rules-reviewed/eap7/eap6/hibernate4.windup.xml)
Please move them into the EAP 8 folder, https://github.com/windup/windup-rulesets/tree/master/rules/rules-reviewed/eap8/eap7 looks like a good fit for them.
mrizzi
requested changes
Feb 8, 2023
rules/rules-reviewed/eap8/eap7/tests/hibernate6.windup.test.xml
Outdated
Show resolved
Hide resolved
github-actions bot
pushed a commit
that referenced
this pull request
Feb 20, 2023
* [WINDUPRULE-899] Ruleset for hibernate orm 6.9 migration * [WINDUPRULE-899] Move hibernate orm 6 target to eap folders * [WINDUPRULE-899] Fix xml related rules (cherry picked from commit 5a0e94d)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
mrizzi
pushed a commit
that referenced
this pull request
Feb 20, 2023
* [WINDUPRULE-899] Ruleset for hibernate orm 6.9 migration * [WINDUPRULE-899] Move hibernate orm 6 target to eap folders * [WINDUPRULE-899] Fix xml related rules (cherry picked from commit 5a0e94d) Co-authored-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See jira ticket.