8000 Restrict IO classes to only Files by agoncal · Pull Request #881 · windup/windup-rulesets · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Restrict IO classes to only Files #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 28, 2023
Merged

Restrict IO classes to only Files #881

merged 3 commits into from
Feb 28, 2023

Conversation

agoncal
Copy link
Contributor
@agoncal agoncal commented Feb 27, 2023

The rules has too many fault postives (eg. IOExcpetion or Serializable). This new rule only focuses on File access

@mrizzi mrizzi self-requested a review February 28, 2023 08:21
mrizzi
mrizzi approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member
@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the enhancement @agoncal 👍

@mrizzi mrizzi merged commit 6427e6a into windup:master Feb 28, 2023
@mrizzi mrizzi added auto-backport Set the PR for being backported auto-backport-to-releases/6.1.z Backport this issue to releases/6.1.z branch labels Feb 28, 2023
github-actions bot pushed a commit that referenced this pull request Feb 28, 2023
@agoncal
Restrict IO classes to only Files (#881)
f1508f1 
* Lombok <1.18.22 is not compatible with JDK 17

* Restrict IO classes to only Files

(cherry picked from commit 6427e6a)
@github-actions github-actions bot mentioned this pull request Feb 28, 2023
Merged
@github-actions
Copy link

💚 All backports created successfully

Status Branch Result
✅ releases/6.1.z

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@github-actions github-actions bot mentioned this pull request Feb 28, 2023
Merged
mrizzi pushed a commit that referenced this pull request Feb 28, 2023
@github-actions @agoncal
Restrict IO classes to only Files (#881) (#883)
3cdd114 
* Lombok <1.18.22 is not compatible with JDK 17

* Restrict IO classes to only Files

(cherry picked from commit 6427e6a)

Co-authored-by: Antonio Goncalves <antonio.goncalves@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrizzi mrizzi mrizzi approved these changes

Assignees
No one assigned
Labels
auto-backport Set the PR for being backported auto-backport-to-releases/6.1.z Backport this issue to releases/6.1.z branch Ready to Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agoncal @mrizzi
0