8000 add more azure rules by KaiqianYang · Pull Request #931 · windup/windup-rulesets · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add more azure rules #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 26, 2023
Merged

add more azure rules #931

merged 6 commits into from
Apr 26, 2023

Conversation

KaiqianYang
Copy link
Contributor

No description provided.

@PhilipCattanach
Copy link
Contributor

Hi @KaiqianYang
Thank you for submitting this PR.
I will get it reviewed today.
Much appreciated.
Phil

@PhilipCattanach
Copy link
Contributor

Hi @KaiqianYang
There doesn't appear to be a windup.test.xml file, or data, for the new azure-os-specific.windup.xml ruleset
Can you add them to the PR please?
Thank you,
Phil

@KaiqianYang
Copy link
Contributor Author

Hi @KaiqianYang Thank you for submitting this PR. I will get it reviewed today. Much appreciated. Phil

@PhilipCattanach Thanks!
And I created a issue found in my testing, thinking it needs attention https://issues.redhat.com/browse/WINDUP-3837

@KaiqianYang
Copy link
Contributor Author
KaiqianYang commented Apr 25, 2023 •
edited
Loading

Hi @KaiqianYang There doesn't appear to be a windup.test.xml file, or data, for the new azure-os-specific.windup.xml ruleset Can you add them to the PR please? Thank you, Phil

@PhilipCattanach Yeah sure, I will add it. And I also created a issue related to this rule, https://issues.redhat.com/browse/WINDUP-3814 . It's a question about OverrideRules. Looking forward to reply.

@PhilipCattanach
Copy link
Contributor

Thanks @KaiqianYang - I'll have a look at https://issues.redhat.com/browse/WINDUP-3814 too and respond in that Jira's comments

@KaiqianYang
Copy link
Contributor Author
KaiqianYang commented Apr 25, 2023 •
edited
Loading

https://issues.redhat.com/browse/WINDUP-3837

Thanks @KaiqianYang - I'll have a look at https://issues.redhat.com/browse/WINDUP-3814 too and respond in that Jira's comments

Thanks @PhilipCattanach. And the issue https://issues.redhat.com/browse/WINDUP-3837 may cause unit test failure

@PhilipCattanach PhilipCattanach merged commit f79e4c6 into windup:master Apr 26, 2023
@mrizzi mrizzi mentioned this pull request Apr 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KaiqianYang @PhilipCattanach
0