8000 Rule that checks Tomcat external resources for Azure migration by agoncal · Pull Request #932 · windup/windup-rulesets · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Rule that checks Tomcat external resources for Azure migration #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 22, 2023
Merged

Rule that checks Tomcat external resources for Azure migration #932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
930bfad
Lombok <1.18.22 is not compatible with JDK 17
agoncal Feb 6, 2023
70aad36
Merge branch 'windup:master' into master
agoncal Feb 23, 2023
8ad7a95
Merge branch 'windup:master' into master
agoncal Apr 24, 2023
c2fbdec
Rule that checks Tomcat external resources for Azure migration
agoncal Apr 25, 2023
7cf4f3f
Update rules/rules-reviewed/azure/tomcat/tests/tomcat-to-azure-extern…
agoncal Apr 28, 2023
600aa2a
Merge branch 'master' into agoncal/tomcatresource
agoncal May 2, 2023
c4e3635
Merge branch 'master' into agoncal/tomcatresource
PhilipCattanach May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions rules/rules-reviewed/azure/tomcat/tests/data/tomcat-to-azure-external-resources/context.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<?xml version="1.0" encoding="UTF-8"?>
<Context>

<WatchedResource>WEB-INF/web.xml</WatchedResource>
<WatchedResource>WEB-INF/tomcat-web.xml</WatchedResource>
<WatchedResource>${catalina.base}/conf/web.xml</WatchedResource>

<Resource name="jdbc/postgres1" auth="Container" type="javax.sql.DataSource"
driverClassName="org.postgresql.Driver" url="jdbc:postgresql://127.0.0.1:5432"
username="postgres" password="yes" maxActive="20" maxIdle="10"
maxWait="-1" />

<Resource name="jdbc/postgres2" auth="Container" type="javax.sql.DataSource"
driverClassName="org.postgresql.Driver" url="jdbc:postgresql://127.0.0.1:5432"
username="postgres" password="yes" maxActive="20" maxIdle="10"
maxWait="-1" />

<NoResource name="jdbc/postgres" auth="Container" type="javax.sql.DataSource"
driverClassName="org.postgresql.Driver" url="jdbc:postgresql://127.0.0.1:5432"
username="postgres" password="yes" maxActive="20" maxIdle="10"
maxWait="-1" />
</Context>
12 changes: 12 additions & 0 deletions .../rules-reviewed/azure/tomcat/tests/data/tomcat-to-azure-external-resources/no-context.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<?xml version="1.0" encoding="UTF-8"?>
<Context>

<WatchedResource>WEB-INF/web.xml</WatchedResource>
<WatchedResource>WEB-INF/tomcat-web.xml</WatchedResource>
<WatchedResource>${catalina.base}/conf/web.xml</WatchedResource>

<Resource name="jdbc/postgres" auth="Container" type="javax.sql.DataSource"
driverClassName="org.postgresql.Driver" url="jdbc:postgresql://127.0.0.1:5432"
username="postgres" password="yes" maxActive="20" maxIdle="10"
maxWait="-1" />
</Context>
22 changes: 22 additions & 0 deletions rules/rules-reviewed/azure/tomcat/tests/tomcat-to-azure-external-resources.windup.test.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<?xml version="1.0"?>
<ruletest id="tomcat-to-azure-external-resources-test" xmlns="http://windup.jboss.org/schema/jboss-ruleset" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://windup.jboss.org/schema/jboss-ruleset http://windup.jboss.org/schema/jboss-ruleset/windup-jboss-ruleset.xsd">
<testDataPath>data/tomcat-to-azure-external-resources</testDataPath>
<rulePath>../tomcat-to-azure-external-resources.windup.xml</rulePath>
<ruleset>
<rules>
<rule id="tomcat-to-azure-external-resources-test-01000">
<when>
<not>
<iterable-filter size="2">
<hint-exists message="External resources, such as data sources, JMS message brokers, and others are injected via Java Naming and Directory Interface \(JNDI\)"/>
</iterable-filter>
</not>
</when>
<perform>
<fail message="External resources found in configuration file hint was not found!"/>
</perform>
</rule>
</rules>
</ruleset>
</ruletest>
39 changes: 39 additions & 0 deletions rules/rules-reviewed/azure/tomcat/tomcat-to-azure-external-resources.windup.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<?xml version="1.0"?>
<ruleset id="tomcat-to-azure-external-resources"
xmlns="http://windup.jboss.org/schema/jboss-ruleset"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://windup.jboss.org/schema/jboss-ruleset http://windup.jboss.org/schema/jboss-ruleset/windup-jboss-ruleset.xsd">
<metadata>
<description>
Identify external resources in a Tomcat configuration file.
</description>
<dependencies>
<addon id="org.jboss.windup.rules,windup-rules-xml,3.0.0.Final" />
</dependencies>
<targetTechnology id="azure-spring-apps"/>
<targetTechnology id="azure-appservice"/>
<targetTechnology id="azure-aks"/>
<targetTechnology id="azure-container-apps"/>
<tag>tomcat</tag>
</metadata>
<rules>
<rule id="tomcat-to-azure-external-resources-01000">
<when>
<xmlfile matches="/Context/Resource" in="context.xml"/>
</when>
<perform>
<hint title="External resources found in configuration file" category-id="cloud-mandatory" effort="5">
<message>
<![CDATA[
External resources, such as data sources, JMS message brokers, and others are injected via Java Naming and Directory Interface (JNDI).

Some such resources may require migration or reconfiguration.
]]>
</message>
<link title="Inventory external resources" href="https://learn.microsoft.com/azure/developer/java/migration/migrate-tomcat-to-azure-spring-apps"/>
<tag>tomcat</tag>
</hint>
</perform>
</rule>
</rules>
</ruleset>
0