8000 WINDUPRULE-982 Versions of Spring compatible with Jakarta EE 9 by PhilipCattanach · Pull Request #936 · windup/windup-rulesets · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

WINDUPRULE-982 Versions of Spring compatible with Jakarta EE 9 #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 19, 2023
Merged

WINDUPRULE-982 Versions of Spring compatible with Jakarta EE 9 #936

merged 12 commits into from
May 19, 2023

Conversation

PhilipCattanach
Copy link
Contributor
@PhilipCattanach PhilipCattanach commented Apr 28, 2023 •
edited by mrizzi
Loading

https://issues.redhat.com/browse/WINDUPRULE-982
A new ruleset that highlights versions of Spring and Spring Boot components that are not compatible with Jakarta EE 9

@PhilipCattanach PhilipCattanach requested a review from jmle April 28, 2023 14:58
mrizzi
mrizzi requested changes May 2, 2023
View reviewed changes
Copy link
Member
@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link test is failing because the https://spring.io/blog/2021/09/02/a-java-17-and-jakarta-ee-9-baseline-for-spring-framework-6" URL redirectes with a 308 HTTP code to https://spring.io/blog/2021/09/02/a-java-17-and-jakarta-ee-9-baseline-for-spring-framework-6/ (/ at the end).

@PhilipCattanach please accept the changes to have the links test to work.

PhilipCattanach and others added 3 commits May 2, 2023 13:25
@PhilipCattanach @mrizzi
Update rules/rules-reviewed/jakarta-ee9/java-ee/spring-components.win…
a14ee9e 
…dup.xml

Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com>
@PhilipCattanach @mrizzi
Update rules/rules-reviewed/jakarta-ee9/java-ee/spring-components.win…
176ac16 
…dup.xml

Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com>
@PhilipCattanach
Merge branch 'master' into WINDUPRULE-982
de04028
mrizzi
mrizzi reviewed May 11, 2023
View reviewed changes
Copy link
Member
@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes on target and versions management

@PhilipCattanach
Copy link
Contributor Author

@mrizzi following the JWS6 meeting I have updated the jws6 technology transformer to include hibernate 6
I tested by building the CLI and running this analysis to ensure the hibernate 6 rules fired.

./windup-cli --input /home/pcattana/Repositories/windup-rulesets/rules/rules-reviewed/eap8/eap7/tests/data/hibernate6 --target jws6 --output $HOME/MTA_Output/JWS6Transformer --sourceMode

@PhilipCattanach PhilipCattanach requested review from mrizzi and removed request for jmle May 18, 2023 14:46
mrizzi
mrizzi approved these changes May 19, 2023
View reviewed changes
Copy link
Member
@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @PhilipCattanach 👍

@mrizzi mrizzi merged commit 91897b5 into windup:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrizzi mrizzi mrizzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilipCattanach @mrizzi
0