8000 [WINDUPRULE-978] Add new ruleset for web technologies by jmle · Pull Request #939 · windup/windup-rulesets · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[WINDUPRULE-978] Add new ruleset for web technologies #939

New issue

Have a question about this project? Sign up for a free GitHub a 8000 ccount to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 15, 2023
Merged

[WINDUPRULE-978] Add new ruleset for web technologies #939

merged 6 commits into from
May 15, 2023

Conversation

jmle
Copy link
Contributor
@jmle jmle commented May 2, 2023 •
edited
Loading

@jmle jmle requested a review from PhilipCattanach May 3, 2023 09:01
@PhilipCattanach
Copy link
Contributor

@jmle Thanks for the PR.
For consistency with all of the technology-usage rules we need the web-technology-usage.windup.xml ruleset to do a graph query on the TechnologyTagModel looking for the name of the technology identified by the web.windup.xml ruleset. Use the embedded-framework rulesets as an example. If we don't update the web-technology-usage.windup.xml then if any of the identification criteria changes then we will have to update it in 2 places.

@mrizzi mrizzi mentioned this pull request May 9, 2023
Merged
@jmle jmle force-pushed the WINDUPRULE-978 branch from a2eca7d to eee5240 Compare May 11, 2023 08:20
@PhilipCattanach
Copy link
Contributor

@jmle - Thanks! The changes look great and they have been successfully tested. It's nice to see the new WebSocket technology tag too.

@PhilipCattanach PhilipCattanach merged commit 3556140 into windup:master May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilipCattanach PhilipCattanach Awaiting requested review from PhilipCattanach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmle @PhilipCattanach
0