8000 WINDUPRULE-996 Refactored 'database' technology rules by mrizzi · Pull Request #963 · windup/windup-rulesets · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

WINDUPRULE-996 Refactored 'database' technology rules #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2023
Merged

WINDUPRULE-996 Refactored 'database' technology rules #963

merged 1 commit into from
May 18, 2023

Conversation

mrizzi
Copy link
Member
@mrizzi mrizzi commented May 18, 2023

@mrizzi mrizzi requested a review from PhilipCattanach May 18, 2023 11:11
@PhilipCattanach
Copy link
Contributor

I have reconciled the old xml ruleset to the new groovy one.
I have ran tests with this pr embedded into the CLI
./windup-cli --input /home/pcattana/Repositories/windup-rulesets/rules/rules-reviewed/technology-usage/tests/data/database --target eap:7 --output $HOME/MTA_Output/database --sourceMode

When using the eap:7 target the EAP 7 link appears, when using the discovery target it doesn't.
Great job, well done @mrizzi

@PhilipCattanach PhilipCattanach merged commit 6f3b93c into windup:master May 18, 2023
@PhilipCattanach PhilipCattanach mentioned this pull request May 18, 2023
Closed
@mrizzi mrizzi deleted the WINDUPRULE-996-database branch May 18, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilipCattanach PhilipCattanach Awaiting requested review from PhilipCattanach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrizzi @PhilipCattanach
0