10000 Renumbering Database rules so it's easier to override by agoncal · Pull Request #978 · windup/windup-rulesets · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Renumbering Database rules so it's easier to override #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 1, 2023
Merged

Renumbering Database rules so it's easier to override #978

merged 5 commits into from
Jun 1, 2023

Conversation

agoncal
Copy link
Contributor
@agoncal agoncal commented Jun 1, 2023

To override a rule we need it's id. This PR sets the ids to a fixed value so it's easier to override and less error prone

@agoncal agoncal changed the title Renumering rules so it's easier to override Renumering Database rules so it's easier to override Jun 1, 2023
@agoncal agoncal changed the title Renumering Database rules so it's easier to override Renumbering Database rules so it's easier to override Jun 1, 2023
mrizzi
mrizzi approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member
@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @agoncal

@mrizzi mrizzi merged commit f1d447f into windup:master Jun 1, 2023
@agoncal agoncal mentioned this pull request Jun 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrizzi mrizzi mrizzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agoncal @mrizzi
0