8000 move apm to technology usage by KaiqianYang · Pull Request #1004 · windup/windup-rulesets · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

move apm to technology usage #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 3, 2023
Merged

move apm to technology usage #1004

merged 8 commits into from
Jul 3, 2023

Conversation

KaiqianYang
Copy link
Contributor

No description provided.

@PhilipCattanach
Copy link
Contributor

Linked to Jira https://issues.redhat.com/browse/WINDUPRULE-1025

@PhilipCattanach
Copy link
Contributor

Hi @KaiqianYang
Can you take another look at this please.
When I test locally with
mvn clean test -f rules/ -DrunTestsMatching=apm -Dtest=WindupRulesTest

the following tests fail

WindupRulesTest.testWindupRules:155
Error with test: apm-test-00000
Cause: (Rule: apm-test-00000) Assertion failed: APM - Application Insights hint was not found!

Error with test: apm-test-00001
Cause: (Rule: apm-test-00001) Assertion failed: APM - New Relic hint was not found!

Error with test: apm-test-00002
Cause: (Rule: apm-test-00002) Assertion failed: APM - Elastic APM hint was not found!

Error with test: apm-test-00003
Cause: (Rule: apm-test-00003) Assertion failed: APM - Dynatrace hint was not found!

@KaiqianYang
Copy link
Contributor Author
KaiqianYang commented Jun 30, 2023 •
edited
Loading

Hi @KaiqianYang Can you take another look at this please. When I test locally with mvn clean test -f rules/ -DrunTestsMatching=apm -Dtest=WindupRulesTest

the following tests fail

WindupRulesTest.testWindupRules:155 Error with test: apm-test-00000 Cause: (Rule: apm-test-00000) Assertion failed: APM - Application Insights hint was not found!

Error with test: apm-test-00001
Cause: (Rule: apm-test-00001) Assertion failed: APM - New Relic hint was not found!

Error with test: apm-test-00002
Cause: (Rule: apm-test-00002) Assertion failed: APM - Elastic APM hint was not found!

Error with test: apm-test-00003
Cause: (Rule: apm-test-00003) Assertion failed: APM - Dynatrace hint was not found!

I saw the error too. Weired thing is, when I do manual test by this command, I can saw all the expected classifications on the page.

./windup-cli.bat -input D:\windup-rulesets\rules\rules-reviewed\technology-usage\tests\data\apm --sourceMode --target discovery --userRulesDirectory "D:\windup-rulesets\rules\rules-reviewed\technology-usage\apm.windup.xml"

image

Already debugged for quite a while but failed to resolve it. I will continue to look at it after back from weekends.

@PhilipCattanach With your expertise, do you have any suggestions?

@agoncal agoncal mentioned this pull request Jun 30, 2023
Closed
@m-brophy m-brophy merged commit be258c8 into windup:master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KaiqianYang @PhilipCattanach @m-brophy
0