10000 [WINDUPRULE-1012] Add rules for the future deprecation of the finalize() methods by jmle · Pull Request #1009 · windup/windup-rulesets · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[WINDUPRULE-1012] Add rules for the future deprecation of the finalize() methods #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2023
Merged

[WINDUPRULE-1012] Add rules for the future deprecation of the finalize() methods #1009

merged 2 commits into from
Jul 25, 2023

Conversation

jmle
Copy link
Contributor
@jmle jmle commented Jul 24, 2023

The finalize() usage search has been implemented as a {*}.finalize() javaclass condition to avoid creating a where clause with many OR'd conditions inside.

See Jira ticket.

@PhilipCattanach
Copy link
Contributor

@jmle The rules worked fine.
Looking at the https://openjdk.org/jeps/421
This change was introduced in OpenJDK18
So I think the source folder should be openjdk17 not openjdk18
If you can rename that folder then we can get it merged.

@jmle jmle mentioned this pull request Jul 25, 2023
Closed
@PhilipCattanach
Copy link
Contributor

All good - thanks @jmle

@PhilipCattanach PhilipCattanach merged commit 20c74d3 into windup:master Jul 25, 2023
This was referenced Jul 27, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmle @PhilipCattanach
0