8000 fix(sdk): some fixes and minor refactoring by marciocadev · Pull Request #7234 · winglang/wing · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(sdk): some fixes and minor refactoring #7234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 6, 2025
Merged

fix(sdk): some fixes and minor refactoring #7234

merged 2 commits into from
Jan 6, 2025

Conversation

marciocadev
Copy link
Collaborator
@marciocadev marciocadev commented Jan 5, 2025 •
edited
Loading

I made two small corrections and a refactoring in this PR:

  1. There was an error in an environment variable related to the bucket name that was passed in the aws-cdk build.
  2. When updating the lambda function log, I assigned the new enum to the old variable, but I have now corrected it to the proper variable.
  3. It didn't make sense to have a file just to keep a global variable related to the Counter, so I removed the file and moved the global variable to the shared-aws/counter.ts file.

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@github-actions GitHub Actions
Copy link
github-actions bot commented Jan 5, 2025

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping use over Discord.

@marciocadev marciocadev marked this pull request as ready for review January 5, 2025 22:02
@marciocadev marciocadev requested a review from a team as a code owner January 5, 2025 22:02
@mergify Mergify
Copy link
Contributor
mergify bot commented Jan 6, 2025

Thanks for contributing, @marciocadev! This PR will now be added to the merge queue, or immediately merged if small-fixes is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Jan 6, 2025
@mergify
Merge of #7234
25e5b23
@mergify mergify bot mentioned this pull request Jan 6, 2025
Closed
16 tasks
@mergify mergify bot merged commit 680203a into winglang:main Jan 6, 2025
13 checks passed
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.85.40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marciocadev @monadabot @eladb
0