Add default example environment file #939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeTowers
reviewed
Jul 6, 2023
|
Arguably a PR could be made to Sail to use our Config Writer package to edit those .env files in a safer and more robust way 😉 |
That's an exellent idea ! I will make the PR this weekend 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an example environment file which is copied to
.envfile on Composer project installation.This is especially useful when you want to start with a dockerized local development environment.
It avoid calling the
php artisan winter:envcommand after a fresh installation which adds unnecessary double quotes and make Laravel Sail installation incompatible.See: https://github.com/laravel/sail/blob/1.x/src/Console/Concerns/InteractsWithDockerComposeServices.php#L118
I'm currently working on a serverless function that generates a bash script to install WinterCMS with Laravel Sail (like Laravel does : https://laravel.com/docs/10.x/installation#laravel-and-docker).
The aim is to set up a standardized dockerized environment quickly and without dependencies (except for Docker).