Change VUV majorValue for better compatibility #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I propose changing the `majorValue` of the VUV currency to be in consistent format with all other values. That is, to use the value 1.0 to indicate that the minor unit does not have a different factor from the major unit. Previously, this was represented by an empty string "", which could cause compatibility issues with some code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose changing the
majorValueof the VUV currency to be in consistent format with all other values. All those values are currently represented as floating point numbers.The only exception is VUV which does not really have a minor unit. This is currently represented as an empty string
"", but that could cause compatibility issues. (At least it has for me).I would like to use the value
1.0to indicate that the minor unit is the same as the major unit. This is more consistent with the logic of the other values.Also I fixed the formatting of the README header.