10000 fix: update type of CollectionEntry ids by fedetibaldo · Pull Request #11435 · withastro/docs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: update type of CollectionEntry ids #11435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2025
Merged

fix: update type of CollectionEntry ids #11435

merged 2 commits into from
Apr 18, 2025
+1 −1

Conversation

fedetibaldo
Copy link
Contributor

Description (required)

The legacy content collections were generating an union of all possible ids. This is no longer the case--it's just a string. This change reflects that.

First-time contributor to Astro Docs?

Yes. @fedetibaldo is my handle on Discord

@fedetibaldo
fix: update type of CollectionEntry ids
ca77cb1 
The legacy content collections were generating an union of all possible ids. This is no longer the case--it's just a string.
@netlify Netlify
Copy link
netlify bot commented Apr 11, 2025 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6034a1d
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/680261aad2a8bb000893d2c9
😎 Deploy Preview https://deploy-preview-11435--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor
astrobot-houston commented Apr 11, 2025 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/modules/astro-content.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@sarah11918
Copy link
Member

Thanks for your patience, @fedetibaldo , while we're a little behind with docs PRs while we've been getting things ready and out for Launch Week!

I'm going to ask @ArmandPhilippot to review this PR for you. I suspect that it is correct as stated: the "Example Type" is meant to give an example as to what the (yes, string) might look like. I believe the type given is shown as an example to be more helpful than just saying that the type will be string, but I will let Armand continue with this PR as he has been helping us standardize our reference types/examples!

@sarah11918 sarah11918 added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label Apr 18, 2025
ArmandPhilippot
ArmandPhilippot approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member
@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed correct. I believe the Example Type is rather what we used with the legacy API and we forgot to update that. I think this change will be more useful because it doesn't imply that autocomplete can be expected here.

Thanks @fedetibaldo and sorry for the delay! Welcome to Team Docs. 🥳

@ArmandPhilippot ArmandPhilippot added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Apr 18, 2025
@sarah11918 sarah11918 merged commit ef4da7e into withastro:main Apr 18, 2025
10 checks passed
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Apr 18, 2025
@ArmandPhilippot
i18n(fr): update modules/astro-content.mdx
5cb7381 
See withastro#11333 and withastro#11435
@ArmandPhilippot ArmandPhilippot mentioned this pull request Apr 18, 2025
Merged
@jsparkdev jsparkdev mentioned this pull request Apr 19, 2025
Merged
@Nin3lee Nin3lee mentioned this pull request Apr 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArmandPhilippot ArmandPhilippot ArmandPhilippot approved these changes

Assignees
No one assigned
Labels
improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fedetibaldo @astrobot-houston @sarah11918 @ArmandPhilippot
0