Update adapters and their deploy guides re: output:'server'
#11497
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
I only left a few suggestions due to typos.
Also, since this is more or less within the scope of this PR, should we update the SSR mentions in the following places:
- (used in integrations guides at the end of the page under
Line 40 in 2fe089c
More integrations, e.g. https://deploy-preview-11497--astro-docs-2.netlify.app/en/guides/integrations-guide/cloudflare/)
I mean it depends on whether we want to update the wording everywhere or keep some for SEO. While search engines are probably smart enough now to make the connection between "server-rendered" and "SSR" (kinda synonyms), maybe having "SSR" explicitly in the page can help with ranking.
Otherwise, looks good to me! But, I would like to point out that, clearly, it's a passion to break the links! 😆 (OK, it would help if the translations were up to date... 😅 )
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
|
Re: Cloudflare deployment page: I remember now, because the Cloudflare deploy guide was recently updated. At the time, we couldn't be bothered to update our pre-built So, I will update the one you mentioned, but we can't totally vanquish it from this page without also updating the component! 🤪 Yes, I think we can update the Update: Oooh, I stand corrected: Looks like I can get at that from the |
|
Oh yeah, that makes sense now, I didn't remember what was said in that PR! Great catch with the other UI string, but it seems these keys (ssr/static) are not used anywhere 😅 They was probably meant for the component, but right now the labels are hardcoded: docs/src/components/tabs/StaticSsrTabs.astro Lines 5 to 12 in 2fe089c Edit: if you want to update the component in this PR, I think we only need to use <Tabs syncKey="deploy-type">
<TabItem label={Astro.locals.t('deploy.staticTag')}>
<slot name="static" />
</TabItem>
<TabItem label={Astro.locals.t('deploy.ssrTag')}>
<slot name="ssr" />
</TabItem>
</Tabs> |
|
Ah, tu as raison! OK, let's change the component while we're here! (Chris is away... we can get away with this...) |
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Description (required)
This PR updates our four adapter guides and their corresponding deploy guides which currently show
output: "server"as the default when you add an adapter.As described in #11245, server mode is not added when running
astro addfor adapters, and it is no longer required (as it was at the time of original writing). Moreover, we now explicitly suggest not to automatically configure server mode, and wait until you have a need for it. So, our examples should not show this as the default configuration when you have an adapter.Additionally, there is duplication in our deploy guides which also show how to add and configure an adapter. These should instead link to the adapter guide to reduce code and maintenance.
Tasks
output: 'server'from standard examplesi18n/en.yml<StaticSSRTabs>component to use translatable tab titlesRelated issues & labels (optional)