8000 fix: update indent and spaces in `guides/deploy/cloudflare.mdx` by jsparkdev · Pull Request #11373 · withastro/docs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: update indent and spaces in guides/deploy/cloudflare.mdx #11373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 5, 2025
Merged

fix: update indent and spaces in guides/deploy/cloudflare.mdx #11373

merged 3 commits into from
Apr 5, 2025

Conversation

jsparkdev
Copy link
Member

Description (required)

  • Add whitespace to improve readability
  • Update invalid indentation in codeblocks

@netlify Netlify
Copy link
netlify bot commented Apr 5, 2025 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a40600c
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67f11419a91d480008d7a052
😎 Deploy Preview https://deploy-preview-11373--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor
astrobot-houston commented Apr 5, 2025 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/deploy/cloudflare.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

sarah11918
sarah11918 reviewed Apr 5, 2025
View reviewed changes
Copy link
Member
@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jsparkdev ! The only change I would revert is the Prerequisites section, since that's the pattern we use in all other deploy guides.

Otherwise, good to merge, thank you for spotting! 💜

@jsparkdev
Copy link
Member Author

@sarah11918

Thanks, I've reverted that part back to the original.

yanthomasdev
yanthomasdev approved these changes Apr 5, 2025
View reviewed changes
Copy link
Member
@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@yanthomasdev yanthomasdev merged commit 8f17609 into withastro:main Apr 5, 2025
10 checks passed
97AD
@ArmandPhilippot ArmandPhilippot mentioned this pull request Apr 5, 2025
Merged
@jsparkdev jsparkdev deleted the some branch April 5, 2025 22:19
@jsparkdev jsparkdev mentioned this pull request Apr 6, 2025
Merged
This was referenced Apr 25, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsparkdev @astrobot-houston @sarah11918 @yanthomasdev
0