Test openNextImg and openPrevImg methods in labelme.app.MainWindow #1575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new GUI test to validate the behavior of the openNextImg and openPrevImg methods in labelme.app.MainWindow. It replaces individual tests with a combined test that checks the boundary condition when attempting to go to a previous image from the first image and then validates navigating forward and back.
Comments suppressed due to low confidence (2)
tests/labelme_tests/test_app.py:76
- Consider using 'qtbot.wait_until' with an appropriate condition rather than a fixed wait time to more reliably wait for the GUI to update.
qtbot.wait(100)
tests/labelme_tests/test_app.py:65
- [nitpick] Consider splitting this combined test into two separate tests for openNextImg and openPrevImg to isolate failures and provide clearer test diagnostics.
def test_MainWindow_openNextAndPrevImg(qtbot: QtBot) -> None:
The existing one doesn't use prev and not enough.
2465fca to
409e006
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new test to verify the behavior of openNextImg and openPrevImg methods in labelme.app.MainWindow. The key changes include:
- Adding test_MainWindow_openNextAndPrevImg to test sequential image navigation.
- Removing individual tests for openNextImg and openPrevImg in favor of a combined test.
Comments suppressed due to low confidence (1)
tests/labelme_tests/test_app.py:76
- Consider replacing the fixed wait(100) with qtbot.wait_until to more robustly synchronize on the expected state change.
qtbot.wait(100)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing one doesn't use prev and not enough.