fix(586): Compare list & scrubber mangles position #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using both the scrubber and the compare list to go to the next or previous image may clobber the current image position. I refactored the compare list to store its position as well as removed all clones for the list. The result is that the scrubber and compare list maintain their own positions. I assume that both lists should have their own set of images (e.g. the scrubber may be open to ~/Pictures while the compare list has whatever images the user added). This patch does not fix that issue, but I can work on that in a separate PR if needed.
|
Thanks for the PR! I think this works great! I apologise for the long delay that this PR has received before being reviewed. I've tested this and I think it all works great. I'll wait for woelpers review as well before merging though. |
Stoppedpuma
approved these changes
May 24, 2025
|
Hi! It's no problem at all. Thank you for reviewing. 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #586
Using both the scrubber and the compare list to go to the next or previous image may clobber the current image position. I refactored the compare list to store its position as well as removed all clones for the list.
The result is that the scrubber and compare list maintain their own positions. I assume that both lists should have their own set of images (e.g. the scrubber may be open to ~/Pictures while the compare list has whatever images the user added). This patch does not fix that issue, but I can work on that in a separate PR if needed.