8000 bump schema and plugin versions by rrennick · Pull Request #415 · woocommerce/action-scheduler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

bump schema and plugin versions #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2020
Merged

bump schema and plugin versions #415

merged 1 commit into from
Jan 10, 2020

Conversation

rrennick
Copy link
Contributor
@rrennick rrennick commented Jan 9, 2020 •
edited
Loading

This PR bumps the schema version for both the DB Store and DB Logger. The plugin version bump will allow this to be used to supersede the 3.0 version included WCS.

The reason for the bump is that some installs that had had the RC installed removed the RC and dropped the tables but left the DB version settings. The schema bump will ensure the tables exist.

Testing

  • Ensure your schema settings are in place
$ wp option get schema-ActionScheduler_StoreSchema
1.0.1578583888
$ wp option get schema-ActionScheduler_LoggerSchema
1.0.1578583888
  • Check whether the migration is marked as complete
wp option get action_scheduler_migration_status
complete
  • Drop the AS tables
mysql> drop table wp_actionscheduler_actions, wp_actionscheduler_groups, wp_actionscheduler_claims, wp_actionscheduler_logs;

  • Activate this branch & load a dashboard screen.

  • Repeat the test with

    • an opposite migration status complete or not set
    • restore the schema version to 1.0.{timestamp}

  • Check after each test to ensure that the tables are created and schema version is updated.

@rrennick rrennick added type: bug The issue is a confirmed bug. custom-tables labels Jan 9, 2020
thenbrent
thenbrent approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor
@thenbrent thenbrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @rrennick!

@thenbrent thenbrent merged commit 15ef561 into master Jan 10, 2020
@thenbrent thenbrent deleted the update/schema-version branch January 10, 2020 08:27
This was referenced Feb 24, 2020
Closed
Closed
@ryanhungate ryanhungate mentioned this pull request May 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thenbrent thenbrent thenbrent approved these changes

Assignees
No one assigned
Labels
type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rrennick @thenbrent
0