8000 Remove the page and search string from status links in list table by rrennick · Pull Request #456 · woocommerce/action-scheduler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove the page and search string from status links in list table #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2020
Merged

Remove the page and search string from status links in list table #456

merged 1 commit into from
Feb 11, 2020

Conversation

rrennick
Copy link
Contributor

This PR fixes an issue in the list table where the status links show a number of actions but when clicked load an empty table.

Reproduce the issue

  • Create a few pending actions in master with a schedule an hour in the future
  • Go to Tools -> Scheduled Actions
  • Go to last page of All
  • Click Pending
  • Go to All
  • Search for one of the pending actions from above
  • Click Complete

Testing

  • Repeat the steps above with this branch

@rrennick rrennick added type: bug The issue is a confirmed bug. Status: Needs Review labels Feb 10, 2020
@rrennick rrennick added this to the 3.0.2 milestone Feb 10, 2020
@rrennick
Copy link
Contributor Author

@thenbrent This one is ready for review.

@thenbrent thenbrent self-requested a review February 11, 2020 01:19
thenbrent
thenbrent approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor
@thenbrent thenbrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@thenbrent thenbrent merged commit 29076a7 into master Feb 11, 2020
@thenbrent thenbrent deleted the fix/list-table-query-string branch February 11, 2020 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thenbrent thenbrent thenbrent approved these changes

Assignees
No one assigned
Labels
type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
3.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@rrennick @thenbrent
0