8000 fix initialization order on activation by rrennick · Pull Request #488 · woocommerce/action-scheduler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix initialization order on activation #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2020
Merged

fix initialization order on activation #488

merged 1 commit into from
Mar 13, 2020

Conversation

rrennick
Copy link
Contributor

Closes #484

This PR fixes the initialization order in the block of code that runs the initialization after init (effectively during activation) to be consistent with the mainline initialization order.

I did some code clean up to address spacing inconsistencies and improve the code readability.

Test by verifying that the plugin still functions normally: Admin screens, actions run, etc.

@rrennick rrennick requested a review from peterfabian March 12, 2020 17:29
@rrennick rrennick added Status: Needs Review type: task The issue is an internally driven task (e.g. from another A8c team). labels Mar 12, 2020
@rrennick rrennick added this to the 3.1.3 milestone Mar 12, 2020
psealock
psealock approved these changes Mar 12, 2020
View reviewed changes
Copy link
@psealock psealock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with wc-admin version/1.0. Jobs due to orders coming in are working well and I see the admin screen updating correctly as well.

@thenbrent thenbrent mentioned this pull request Mar 12, 2020
Merged
@thenbrent
Copy link
Contributor

This should be tested with #487 applied too, because that PR updates bulk deletion to use ActionScheduler::store(). ActionScheduler::store()->init() will need to have been called before that's usable.

@rrennick
Copy link
Contributor Author

This should be tested with #487 applied too

This tested fine in both Tools -> Scheduled Actions and WooCommerce -> Status -> Scheduled Actions.

@rrennick rrennick merged commit 24ccd7d into master Mar 13, 2020
@rrennick rrennick deleted the issue_484 branch March 13, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psealock psealock psealock approved these changes

@peterfabian peterfabian Awaiting requested review from peterfabian

Assignees
No one assigned
Labels
type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
None yet
Milestone
3.1.3
Development

Successfully merging this pull request may close these issues.

Init order
3 participants
@rrennick @thenbrent @psealock
0