8000 [fix] Add missing `from_str` annotation to the x25519.py stubs by padraic-padraic · Pull Request #37 · woodruffw/pyrage · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[fix] Add missing from_str annotation to the x25519.py stubs #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2023
Merged

[fix] Add missing from_str annotation to the x25519.py stubs #37

merged 1 commit into from
Aug 1, 2023

Conversation

padraic-padraic
Copy link
Contributor

Thank you for your work on pyrage!

When developing something using x25519 identities, I noticed that the stubs are missing an annotation for the from_str class method that was making my editor complain. This PR adds the missing annotation.

woodruffw
woodruffw approved these changes Aug 1, 2023
View reviewed changes
Copy link
Owner
@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated, thanks @padraic-padraic!

@woodruffw woodruffw merged commit 0c883c9 into woodruffw:main Aug 1, 2023
@woodruffw
Copy link
Owner

Thanks again. I'll cut a stubs release shortly.

@woodruffw
Copy link
Owner

Released as stubs version 1.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw woodruffw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@padraic-padraic @woodruffw
0