-
Notifications
You must be signed in to change notification settings - Fork 0
Create new USDC stream #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ftware/comet into woof-software/create-usdc-stream
constructor(address _receiver) { | ||
if(_receiver == address(0)) revert ZeroAddress(); | ||
|
||
compOracleDecimals = AggregatorV3Interface(COMP_ORACLE).decimals(); | ||
usdcOracleDecimals = AggregatorV3Interface(USDC_ORACLE).decimals(); | ||
receiver = _receiver; | ||
} |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.performance.non-payable-constructor Note
if( | ||
msg.sender != receiver && | ||
block.timestamp < lastClaimTimestamp + 7 days | ||
) revert NotReceiver(); |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.performance.use-nested-if Note
There are more advantages, such as easier to read code and better coverage reports.
} | ||
|
||
lastClaimTimestamp = block.timestamp; | ||
suppliedAmount += owed; |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.performance.inefficient-state-variable-increment Note
|
||
lastClaimTimestamp = block.timestamp; | ||
suppliedAmount += owed; | ||
claimedCompAmount += compAmount; |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.performance.inefficient-state-variable-increment Note
if( | ||
msg.sender != COMPOUND_TIMELOCK && | ||
block.timestamp < startTimestamp + STREAM_DURATION + 10 days | ||
) revert StreamNotFinished(); |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.performance.use-nested-if Note
There are more advantages, such as easier to read code and better coverage reports.
params:
Recipient - 0xc10785fB7b1adD4fD521A27d0d55c5561EEf0940
Seed - 17710 COMP
Distribute 700,000 USDC
Duration - 2 months
Slippage - 0.5%