Fix vendor.cmake #1082
Fix vendor.cmake #1082
Conversation
for package managers such as vcpkg and homebrew
6bf3f7d to
d183877
Compare
|
I don't understand how you expect this to work, when there's a need for specific patches to be applied (which you are just ignoring), or when the library explicitly forbids what you want to do (as explained in #1079). The amount of libraries retrieved via CPM will only increase, and downstream needs to adapt to this. See https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=moderncore if you need guidance. |
|
@wolfpld I see CPM.cmake and FetchContent() can be disabled: -DCPM_LOCAL_PACKAGES_ONLY=ON find_package() is called inside CPMAddPackage() That's my workaround These changes are not finished |
Will this increase be limited to what is used by the executables, or will it also affect the libraries? |
|
I don't expect the libraries to be affected. The intention is that you can just dump the Tracy client sources into your application and have everything working with minimal effort required. |
Your latest releases cannot be used (without hacks and patches) with vcpkg and Homebrew because they prohibit external downloads that CPM.cmake does
pkg_check_modules(CAPSTONE capstone)
pkg_check_modules(GLFW glfw3)
pkg_check_modules(FREETYPE freetype2)
...
https://github.com/Homebrew/homebrew-core/blob/badf764aab60b495bb699e23ab3b1633f588df50/Formula/t/tracy.rb
depends_on "glfw"
depends_on "capstone"
depends_on "freetype"
https://github.com/microsoft/vcpkg/blob/master/ports/tracy/vcpkg.json
"dependencies": [
{
"name": "capstone",
"features": [
"arm",
"arm64",
"x86"
]
},
...
"freetype",
"glfw3",
...
]
Please, use the same approach and check that modules are already installed:
pkg_check_modules(ZSTD libzstd)
pkg_check_modules(ImGui imgui)
pkg_check_modules(NFD nfd)
pkg_check_modules(PPQSORT ppqsort)
(I'm checking that these names and CMake variables are correct)
https://github.com/btzy/nativefiledialog-extended/blob/master/src/CMakeLists.txt nfd
https://github.com/GabTux/PPQSort/blob/master/standalone/CMakeLists.txt PPQSort::PPQSort
https://github.com/facebook/zstd/tree/dev/lib
O_o
https://github.com/conan-io/conan-center-index/blob/master/recipes/imgui/all/CMakeLists.txt
https://github.com/microsoft/vcpkg/blob/master/ports/imgui/CMakeLists.txt